Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReservationCapacityExceeded error in aws_instance #33412

Merged
1 commit merged into from
Feb 9, 2024
Merged

Fix ReservationCapacityExceeded error in aws_instance #33412

1 commit merged into from
Feb 9, 2024

Conversation

atikhono
Copy link
Contributor

Description

When aws_instance has instance_type and capacity reservation ID changes, the provider performs both changes in stop/start context.

Relations

Closes #32458

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Sep 11, 2023
@github-actions
Copy link

Hey @atikhono 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 11, 2023
github-actions[bot]
github-actions bot reviewed Sep 11, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @atikhono 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 11, 2023
@atikhono atikhono force-pushed the bugfix/reservation-capacity-exceeded branch from e517314 to bd03200 Compare September 21, 2023 13:44
@breathingdust breathingdust added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 24, 2023
@ewbankkit ewbankkit self-assigned this Feb 9, 2024
@ewbankkit ewbankkit mentioned this pull request Feb 9, 2024
Merged
@ewbankkit
Copy link
Contributor

@atikhono Thanks for the contribution 🎉 👏.
I have rolled your work into #35745 to get this fixed promptly.

@ewbankkit ewbankkit closed this pull request by merging all changes into hashicorp:main in 164f0e2 Feb 9, 2024
@github-actions github-actions bot added this to the v5.37.0 milestone Feb 9, 2024
@atikhono atikhono deleted the bugfix/reservation-capacity-exceeded branch February 12, 2024 09:13
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 15, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@unflag unflag unflag approved these changes

Assignees

@ewbankkit ewbankkit

Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v5.37.0
5 participants
@atikhono @ewbankkit @unflag @breathingdust @justinretzolk